Skip to content

fix: rollback the reconnect after 10MB behavior after the fix for omg… #1530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stephaniewang526 merged 2 commits into from
Feb 11, 2022
Merged

fix: rollback the reconnect after 10MB behavior after the fix for omg… #1530

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
12142e7
fix: rollback the reconnect after 10MB behavior after the fix for omg…
yirutang Feb 9, 2022
dee703e
.
yirutang Feb 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions ...-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1/JsonStreamWriter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -405,15 +405,16 @@ public Builder setIgnoreUnknownFields(boolean ignoreUnknownFields) {
}

/**
* Setter for a reconnectAfter10M, temporaily workaround for omg/48020. Fix for the omg is
* supposed to roll out by 2/11/2022 Friday. If you set this to True, your write will be slower
* (0.75MB/s per connection), but your writes will not be stuck as a sympton of omg/48020.
* @Deprecated Setter for a reconnectAfter10M, temporaily workaround for omg/48020. Fix for the
* omg is supposed to roll out by 2/11/2022 Friday. If you set this to True, your write will be
* slower (0.75MB/s per connection), but your writes will not be stuck as a sympton of
* omg/48020.
*
* @param reconnectAfter10M
* @return Builder
*/
public Builder setReconnectAfter10M(boolean reconnectAfter10M) {
this.reconnectAfter10M = reconnectAfter10M;
this.reconnectAfter10M = false;
return this;
}

Expand Down