Skip to content

fix: remove pre launch comments from enableConnectionPool #2215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yirutang merged 3 commits into from
Jul 28, 2023
Merged

fix: remove pre launch comments from enableConnectionPool #2215

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8e61024
fix: remove pre launch comments from enableConnectionPool
yirutang Jul 27, 2023
ee954b7
.
yirutang Jul 27, 2023
822eeae
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Jul 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ If you are using Maven without the BOM, add this to your dependencies:
If you are using Gradle 5.x or later, add this to your dependencies:

```Groovy
implementation platform('com.google.cloud:libraries-bom:26.19.0')
implementation platform('com.google.cloud:libraries-bom:26.20.0')

implementation 'com.google.cloud:google-cloud-bigquerystorage'
```
Expand Down
3 changes: 1 addition & 2 deletions ...-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1/JsonStreamWriter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -313,8 +313,7 @@ public Builder setReconnectAfter10M(boolean reconnectAfter10M) {

/**
* Enable multiplexing for this writer. In multiplexing mode tables will share the same
* connection if possible until the connection is overwhelmed. This feature is still under
* development, please contact write api team before using.
* connection if possible until the connection is overwhelmed.
*
* @param enableConnectionPool
* @return Builder
Expand Down
3 changes: 1 addition & 2 deletions ...loud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1/StreamWriter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -636,8 +636,7 @@ public Builder setEndpoint(String endpoint) {

/**
* Enable multiplexing for this writer. In multiplexing mode tables will share the same
* connection if possible until the connection is overwhelmed. This feature is still under
* development, please contact write api team before using.
* connection if possible until the connection is overwhelmed.
*
* @param enableConnectionPool
* @return Builder
Expand Down