Skip to content

Conversation

@PhongChuong
Copy link
Contributor

@PhongChuong PhongChuong commented Oct 8, 2024

com.google.cloud.opentelemetry.exporter-metrics depends on a very old version of com.google.cloud.google-cloud-monitoring which conflicts with newer com.google.cloud.google-cloud-bigquery builds

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #2667 #2668 #2669 #2670 #2671 #2672 #2673 #2674 ☕️

com.google.cloud.opentelemetry.exporter-metrics depends on a very old version of com.google.cloud.google-cloud-monitoring which conflicts with newer com.google.cloud.google-cloud-bigquery builds
@generated-files-bot
Copy link

Warning: This pull request is touching the following templated files:

  • samples/install-without-bom/pom.xml
  • samples/snapshot/pom.xml

@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. samples Issues that are directly related to samples. labels Oct 8, 2024
@PhongChuong PhongChuong marked this pull request as ready for review October 8, 2024 20:03
@PhongChuong PhongChuong requested review from a team as code owners October 8, 2024 20:03
@PhongChuong PhongChuong requested a review from farhan0102 October 8, 2024 20:03
@PhongChuong
Copy link
Contributor Author

It seems like com.google.cloud.opentelemetry:exporter-metrics v0.33.0 fixed the dependency conflict issue which was merged in PR#2696. Holding this PR until that is confirmed.

@PhongChuong
Copy link
Contributor Author

It seems like #2696 fixed the issue. This is no longer needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. samples Issues that are directly related to samples. size: s Pull request size is small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

com.example.bigquerystorage.JsonWriterStreamCdcIT: testJsonWriterStreamCdc failed

3 participants