Skip to content

feat: add client debug logging support for streaming gRPC/REST calls #794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
parthea wants to merge 8 commits into from
Closed

feat: add client debug logging support for streaming gRPC/REST calls #794

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
2123298
feat: add client debug logging support for unary-stream gRPC calls
parthea Feb 14, 2025
5510056
mypy
parthea Feb 14, 2025
3fb362f
coverage
parthea Feb 19, 2025
d73d18c
include debug log for first result in grpc unary->stream calls
parthea Feb 19, 2025
826c79b
add debug logs for rest streaming
parthea Feb 19, 2025
230fe9a
result->response_payload
parthea Feb 19, 2025
9fac30c
cover
parthea Feb 19, 2025
56810ca
Merge branch 'main' into add-unary-stream-logging
parthea Mar 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
mypy
  • Loading branch information
@parthea
parthea committed Mar 19, 2025
commit 551005610b4009998246196f8f4b9a2fff11879d
2 changes: 1 addition & 1 deletion google/api_core/grpc_helpers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ def __next__(self) -> P:
response_payload = google.protobuf.json_format.MessageToJson(result)
else:
response_payload = (
f"{type(result).__name__}: {pickle.dumps(result)}"
f"{type(result).__name__}: {str(pickle.dumps(result))}"
)
grpc_response = {
"payload": response_payload,
Expand Down
2 changes: 1 addition & 1 deletion google/api_core/grpc_helpers_async.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ async def read(self) -> P:
response_payload = google.protobuf.json_format.MessageToJson(result)
else:
response_payload = (
f"{type(result).__name__}: {pickle.dumps(result)}"
f"{type(result).__name__}: {str(pickle.dumps(result))}"
)
grpc_response = {
"payload": response_payload,
Expand Down