Skip to content

fix: pass timeout to 'PartialRowsData.response_iterator' #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tseaver merged 8 commits into from
Sep 2, 2020
Merged

fix: pass timeout to 'PartialRowsData.response_iterator' #16

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
a692884
fix: cbt-6 [added timeout value to PartialRowsData.response_iterator]
mf2199 Mar 31, 2020
2f69b38
Reverting to using the existing Retry._deadline member
mf2199 Apr 1, 2020
9bd6386
Merge branch 'master' into #6---Bigtable-read_rows-no-deadline
mf2199 May 28, 2020
1f938a5
fix: added test for `retry.timeout value`
mf2199 Jun 2, 2020
1ad1f35
Merge branch 'master' into #6---Bigtable-read_rows-no-deadline
mf2199 Jun 9, 2020
a132409
Merge branch 'master' into #6---Bigtable-read_rows-no-deadline
mf2199 Jul 2, 2020
56884c0
test: adding relevant test following dependency release
mf2199 Aug 17, 2020
7270400
docs: added comment
mf2199 Aug 19, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: adding relevant test following dependency release
  • Loading branch information
@mf2199
mf2199 committed Aug 17, 2020
commit 56884c03c4645fadea662d3a3280b41e323ef92d
4 changes: 3 additions & 1 deletion tests/unit/test_row_data.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -392,7 +392,9 @@ def test_constructor_with_retry(self):
request = object()
retry = DEFAULT_RETRY_READ_ROWS
partial_rows_data = self._make_one(client._data_stub.ReadRows, request, retry)
# self.assertEqual(partial_rows_data.response_iterator.timeout, 60.0)
partial_rows_data.read_method.assert_called_once_with(
request, timeout=DEFAULT_RETRY_READ_ROWS.deadline + 1
)
self.assertIs(partial_rows_data.request, request)
self.assertEqual(partial_rows_data.rows, {})
self.assertEqual(partial_rows_data.retry, retry)
Expand Down