Skip to content

fix: respect deadlines for column family operations #687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
igorbernstein2 merged 3 commits into from
Oct 20, 2022
Merged

fix: respect deadlines for column family operations #687

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8f2485e
feat: allow end users to override the deadline for manipulating colum…
igorbernstein2 Oct 20, 2022
0fdf13b
limit scope of change to just use the default timeout
igorbernstein2 Oct 20, 2022
dbccec8
lint
igorbernstein2 Oct 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions google/cloud/bigtable/column_family.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
from google.cloud.bigtable_admin_v2.types import (
bigtable_table_admin as table_admin_v2_pb2,
)
from google.api_core.gapic_v1.method import DEFAULT


class GarbageCollectionRule(object):
Expand Down Expand Up @@ -275,7 +276,8 @@ def create(self):
# data it contains are the GC rule and the column family ID already
# stored on this instance.
client.table_admin_client.modify_column_families(
request={"name": self._table.name, "modifications": [modification]}
request={"name": self._table.name, "modifications": [modification]},
timeout=DEFAULT,
)

def update(self):
Expand All @@ -302,7 +304,8 @@ def update(self):
# data it contains are the GC rule and the column family ID already
# stored on this instance.
client.table_admin_client.modify_column_families(
request={"name": self._table.name, "modifications": [modification]}
request={"name": self._table.name, "modifications": [modification]},
timeout=DEFAULT,
)

def delete(self):
Expand All @@ -324,7 +327,8 @@ def delete(self):
# data it contains are the GC rule and the column family ID already
# stored on this instance.
client.table_admin_client.modify_column_families(
request={"name": self._table.name, "modifications": [modification]}
request={"name": self._table.name, "modifications": [modification]},
timeout=DEFAULT,
)


Expand Down