-
Notifications
You must be signed in to change notification settings - Fork 62
feat: improve rows filters #751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
daniel-sanche
merged 16 commits into
googleapis:v3
from
daniel-sanche:v3_read_rows_filters
Mar 23, 2023
Merged
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
7ce1975
added to_dict to filters
daniel-sanche e78dac7
added filters tests
daniel-sanche 906ed33
ignore tests for mypy
daniel-sanche fcabba5
added str and repr for row filters
daniel-sanche 5367e8e
renamed base filter to predicate filter
daniel-sanche 22d476e
fixed some print bytes formatting
daniel-sanche 0e4eb5d
renamed family and qualifier variables to be consistent with new classes
daniel-sanche 73b187f
filter combination implements sequence abc
daniel-sanche d7f1f7f
fixed mypy issues
daniel-sanche 4518119
made to_pb private
daniel-sanche ad11eb3
changed annotations
daniel-sanche b4ce551
added str and repr tests
daniel-sanche d60ec7f
update date in test file header
daniel-sanche a4ede76
made abstract classes for filters
daniel-sanche 0e8d3b1
test trying to construct abstract classes
daniel-sanche 8f30d8e
made cellcountfilter abc
daniel-sanche File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
added str and repr for row filters
- Loading branch information
commit fcabba5767316b67131620e7bca871cb67314015
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think of creating an ABC using abc.ABC for
RowFilterso thatto_dictcan be one of its@abstractmethodThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I think that makes sense. The only complication is that it requires us to make other filter subclasses abstract as well (_BoolFilter, _FilterCombination, _CellCountFilter), but that's probably good to prevent users from instantiating them directly anyway
I made the changes, let me know what you think