Skip to content

feat: add quota_project, credentials file, and scopes options #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tseaver merged 6 commits into from
Aug 4, 2020
Merged

feat: add quota_project, credentials file, and scopes options #15

tseaver merged 6 commits into from
Aug 4, 2020

Conversation

@busunkim96
Copy link
Contributor

@busunkim96 busunkim96 commented Aug 1, 2020 •
edited by tseaver
Loading

Manual clients need to support the new client_options logic.

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 1, 2020
@busunkim96 busunkim96 force-pushed the client-options-update branch from 9d5ae26 to f39170a Compare August 1, 2020 04:58
tseaver
tseaver suggested changes Aug 4, 2020
View reviewed changes
Copy link
Contributor

@tseaver tseaver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs coverage for the new codepaths in Client.__init__ (options passed as dict, conflict between credentials and client_options.credientials_file, etc.

This was referenced Aug 4, 2020
Closed
Closed
tseaver
tseaver reviewed Aug 4, 2020
View reviewed changes
@google-cla
Copy link

google-cla bot commented Aug 4, 2020

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Aug 4, 2020
@tseaver
Copy link
Contributor

tseaver commented Aug 4, 2020

@googlebot I consent

@google-cla google-cla bot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Aug 4, 2020
This was referenced Aug 4, 2020
Closed
Closed
Closed
Closed
Closed
@tseaver tseaver merged commit a1e11e1 into master Aug 4, 2020
@tseaver tseaver deleted the client-options-update branch August 4, 2020 19:42
@larkee larkee mentioned this pull request Aug 5, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@tseaver tseaver tseaver approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@busunkim96 @tseaver