Skip to content

feat: allow custom labels with standard library logging #264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
daniel-sanche merged 21 commits into from
Apr 22, 2021
Merged

feat: allow custom labels with standard library logging #264

Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
1714f44
improved source location handling
daniel-sanche Apr 15, 2021
5edf4e4
improved some tests
daniel-sanche Apr 15, 2021
d357032
all handlers send source location
daniel-sanche Apr 15, 2021
490d455
fixed missing ,
daniel-sanche Apr 15, 2021
9e173fd
fixed issues with unit tests
daniel-sanche Apr 15, 2021
21279a9
fixed lint issues
daniel-sanche Apr 15, 2021
556ecd8
updated environment tests
daniel-sanche Apr 15, 2021
3dccd1a
add log filter to CloudLoggingHandler
daniel-sanche Apr 15, 2021
7842536
updated tests
daniel-sanche Apr 16, 2021
125ae82
Merge branch 'v2_update_2' into improve-source-location
daniel-sanche Apr 16, 2021
1b4e7ff
improved label handling
daniel-sanche Apr 20, 2021
b084cd9
fixed tests
daniel-sanche Apr 20, 2021
5e1f22b
added better comment
daniel-sanche Apr 20, 2021
0d5e4bb
Merge branch 'improve-source-location' into override_labels
daniel-sanche Apr 20, 2021
78f8ca2
added new environment test
daniel-sanche Apr 20, 2021
790d19a
Merge branch 'v2_update_2' into override_labels
daniel-sanche Apr 20, 2021
f19c33e
fixed broken test
daniel-sanche Apr 20, 2021
99b4f58
fixed labels on structured logging handler
daniel-sanche Apr 20, 2021
0baa60a
fixed lint
daniel-sanche Apr 20, 2021
54ff4bc
fixed unit tests
daniel-sanche Apr 20, 2021
09fcf6b
updated environment tests
daniel-sanche Apr 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixed unit tests
  • Loading branch information
@daniel-sanche
daniel-sanche committed Apr 20, 2021
commit 54ff4bc7b525bfcefded19b2371a252936c78f31
16 changes: 7 additions & 9 deletions tests/unit/handlers/test_structured_log.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ def test_format(self):
"userAgent": "",
"protocol": "",
},
"logging.googleapis.com/labels": str(labels),
"logging.googleapis.com/labels": labels,
}
handler.filter(record)
result = json.loads(handler.format(record))
Expand Down Expand Up @@ -108,7 +108,7 @@ def test_format_minimal(self):
"userAgent": "",
"protocol": "",
},
"logging.googleapis.com/labels": "{}",
"logging.googleapis.com/labels": {},
}
handler.filter(record)
result = json.loads(handler.format(record))
Expand Down Expand Up @@ -194,13 +194,11 @@ def test_format_overrides(self):
"userAgent": "",
"protocol": "",
},
"logging.googleapis.com/labels": str(
{
"default_key": "default-value",
"overwritten_key": "new_value",
"added_key": "added_value",
}
),
"logging.googleapis.com/labels": {
"default_key": "default-value",
"overwritten_key": "new_value",
"added_key": "added_value",
},
}

app = self.create_app()
Expand Down