Skip to content

fix: mimic the pubsub test to clean up bigquery datasets #639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
leahecole merged 3 commits into from
Sep 30, 2022
Merged

fix: mimic the pubsub test to clean up bigquery datasets #639

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
171f9a5
fix: mimic the pubsub test to clean up bigquery datasets
leahecole Sep 30, 2022
b106b4c
Merge branch 'main' into fix_635
leahecole Sep 30, 2022
7d7ad87
fix: add explanatory comment
leahecole Sep 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions samples/snippets/usage_guide.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -315,13 +315,19 @@ def _sink_bigquery_setup(client):
client.update_dataset(dataset, ["access_entries"]) # API call
# [END sink_dataset_permissions]

return dataset
# create callback wrapper to delete dataset when done
class DatasetDeleter:
def delete(self):
client.delete_dataset(dataset, delete_contents=True)

return dataset, DatasetDeleter()


@snippet
def sink_bigquery(client, to_delete):
"""Sink log entries to bigquery."""
dataset = _sink_bigquery_setup(client)
dataset, dataset_deleter = _sink_bigquery_setup(client)
to_delete.append(dataset_deleter)
sink_name = "robots-bigquery-%d" % (_millis(),)
filter_str = "textPayload:robot"

Expand Down