Skip to content

fix: connection reset fails when an additional dialect is used #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
IlyaFaer merged 2 commits into from
Jan 10, 2022
Merged

fix: connection reset fails when an additional dialect is used #188

IlyaFaer merged 2 commits into from
Jan 10, 2022

Conversation

@IlyaFaer
Copy link
Contributor

@IlyaFaer IlyaFaer commented Jan 7, 2022 •
edited
Loading

Closes #186

@IlyaFaer IlyaFaer added the type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. label Jan 7, 2022
@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/python-spanner-sqlalchemy API. label Jan 7, 2022
@IlyaFaer IlyaFaer marked this pull request as ready for review January 7, 2022 11:02
@IlyaFaer IlyaFaer requested a review from vi3k6i5 January 7, 2022 11:03
@ansh0l ansh0l requested a review from larkee January 7, 2022 11:57
@ansh0l
Copy link
Contributor

ansh0l commented Jan 7, 2022

@larkee : Please have a look at this for review.

@ansh0l ansh0l requested a review from asthamohta January 7, 2022 11:59
ansh0l
ansh0l reviewed Jan 7, 2022
View reviewed changes
@aderk aderk mentioned this pull request Jan 7, 2022
Closed
aderk
aderk reviewed Jan 7, 2022
View reviewed changes
vi3k6i5
vi3k6i5 approved these changes Jan 10, 2022
View reviewed changes
Copy link
Contributor

@vi3k6i5 vi3k6i5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@IlyaFaer IlyaFaer merged commit 417b8b8 into main Jan 10, 2022
@IlyaFaer IlyaFaer deleted the connection_reset branch January 10, 2022 07:29
@hadim hadim mentioned this pull request Jan 10, 2022
Closed
@release-please release-please bot mentioned this pull request Jan 27, 2022
Merged
@JoudZouzou JoudZouzou mentioned this pull request Jun 17, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@larkee larkee Awaiting requested review from larkee

@asthamohta asthamohta Awaiting requested review from asthamohta

3 more reviewers

@ansh0l ansh0l ansh0l left review comments

@aderk aderk aderk left review comments

@vi3k6i5 vi3k6i5 vi3k6i5 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: spanner Issues related to the googleapis/python-spanner-sqlalchemy API. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Use of python-spanner-alchemy breaks sqlalchemy-sqlite

4 participants

@IlyaFaer @ansh0l @vi3k6i5 @aderk