Skip to content

Conversation

@IlyaFaer
Copy link
Contributor

@IlyaFaer IlyaFaer commented Jan 17, 2022

Branched from another PR: #189
Fixes: #192

By default connection reset function rollbacks any connection returned back to pool. Adding this behaviour into our override.

@IlyaFaer IlyaFaer added the type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. label Jan 17, 2022
@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/python-spanner-sqlalchemy API. label Jan 17, 2022
@vi3k6i5
Copy link
Contributor

vi3k6i5 commented Jan 28, 2022

Hi @IlyaFaer : Can you fix the conflict in the PR?

PS: Anything I can help with so you can send it out for review?

@IlyaFaer
Copy link
Contributor Author

@vi3k6i5, first we should merge another PR: #189

@vi3k6i5
Copy link
Contributor

vi3k6i5 commented Jan 28, 2022

@IlyaFaer : #189 is now merger.

@IlyaFaer IlyaFaer marked this pull request as ready for review January 28, 2022 11:24
@IlyaFaer IlyaFaer requested a review from vi3k6i5 January 28, 2022 11:24
Copy link
Contributor

@vi3k6i5 vi3k6i5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vi3k6i5 vi3k6i5 merged commit 13ff9cb into main Jan 28, 2022
@vi3k6i5 vi3k6i5 deleted the rollback_conn branch January 28, 2022 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: spanner Issues related to the googleapis/python-spanner-sqlalchemy API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ValueError: staleness option can't be changed while a transaction is in progress

2 participants