Skip to content

fix: delete stale instance with delay of 5 seconds #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vi3k6i5 merged 2 commits into from
Jan 27, 2022
Merged

fix: delete stale instance with delay of 5 seconds #194

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7a3c055
fix: delete stale instance with delay of 5 seconds
vi3k6i5 Jan 18, 2022
db5ba8d
Merge branch 'main' into ft-instance-cleanup
vi3k6i5 Jan 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion create_test_database.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,8 @@
USE_EMULATOR = os.getenv("SPANNER_EMULATOR_HOST") is not None

PROJECT = os.getenv(
"GOOGLE_CLOUD_PROJECT", os.getenv("PROJECT_ID", "emulator-test-project"),
"GOOGLE_CLOUD_PROJECT",
os.getenv("PROJECT_ID", "emulator-test-project"),
)
CLIENT = None

Expand Down Expand Up @@ -56,6 +57,7 @@ def delete_stale_test_instances():
# therefore instance can just be deleted.
try:
instance.delete()
time.sleep(5) # Sleep for 5 seconds to give time for cooldown.
except ResourceExhausted:
print(
"Unable to drop stale instance '{}'. May need manual delete.".format(
Expand Down