Skip to content

feat: add query statistics package support #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
larkee merged 3 commits into from
Jun 7, 2021
Merged

feat: add query statistics package support #129

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7f926f7
feat: add query statistics package support
larkee Aug 6, 2020
ae6a8ba
style: fix lint
larkee Apr 8, 2021
b249ebb
test: reorder env mocks
larkee Jun 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
style: fix lint
  • Loading branch information
@larkee
larkee committed Jun 7, 2021
commit ae6a8ba3d13ec6cd6d5c0829fb9bd5b4251a7089
2 changes: 1 addition & 1 deletion google/cloud/spanner_v1/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@ def __init__(

env_query_options = ExecuteSqlRequest.QueryOptions(
optimizer_version=_get_spanner_optimizer_version(),
optimizer_statistics_package=_get_spanner_optimizer_statistics_package()
optimizer_statistics_package=_get_spanner_optimizer_statistics_package(),
)

# Environment flag config has higher precedence than application config.
Expand Down
5 changes: 1 addition & 4 deletions tests/unit/test_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,10 +103,7 @@ def _constructor_test_helper(
expected_client_options.api_endpoint,
)
if expected_query_options is not None:
self.assertEqual(
client._query_options,
expected_query_options
)
self.assertEqual(client._query_options, expected_query_options)

@mock.patch("google.cloud.spanner_v1.client._get_spanner_emulator_host")
@mock.patch("warnings.warn")
Expand Down