sorting keys and adding separators

google/cloud/spanner_v1/_helpers.py

@@ -131,8 +131,6 @@ def _make_value_pb(value):
         return Value(list_value=value)
     if isinstance(value, decimal.Decimal):
         return Value(string_value=str(value))
-    if isinstance(value, dict):
-        return Value(string_value=value)
     raise ValueError("Unknown type: %s" % (value,))
 
 

tests/system/test_system.py

@@ -1075,18 +1075,18 @@ def test_list_backups(self):
 NUMERIC_1 = decimal.Decimal("0.123456789")
 NUMERIC_2 = decimal.Decimal("1234567890")
 JSON_1 = json.dumps({
-        "sample_string" : "abcdef",
-        "sample_int" : 872163,
+        "sample_array" : [23, 76, 19],
         "sample_boolean" : True,
+        "sample_int" : 872163,
         "sample_null" : None,
-        "sample_array" :[23, 76, 19]
-    })
+        "sample_string" : "abcdef",
+    }, sort_keys=True, separators=(',', ':'))
 JSON_2 = json.dumps({
     "sample_object" : {
             "name" : "Anamika",
             "id" : 2635
         }
-    })
+    }, sort_keys=True, separators=(',', ':'))
 
 ALL_TYPES_TABLE = "all_types"
 ALL_TYPES_COLUMNS = (

tests/unit/test__helpers.py

@@ -236,7 +236,7 @@ def test_w_json(self):
         value = json.dumps({
             "id" : 27863,
             "Name" : "Anamika"
-        })
+        }, sort_keys=True, separators=(',', ':'))
         value_pb = self._callFUT(value)
         self.assertIsInstance(value_pb, Value)
         self.assertEqual(value_pb.string_value, value)
@@ -511,7 +511,7 @@ def test_w_json(self):
         VALUE = json.dumps({
             "id" : 27863,
             "Name" : "Anamika"
-        })
+        }, sort_keys=True, separators=(',', ':'))
         field_type = Type(code=TypeCode.JSON)
         value_pb = Value(string_value=VALUE)