Skip to content

feat: set a separate user agent for the DB API #566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
larkee merged 3 commits into from
Sep 13, 2021
Merged

feat: set a separate user agent for the DB API #566

larkee merged 3 commits into from
Sep 13, 2021

Conversation

@IlyaFaer
Copy link
Contributor

@IlyaFaer IlyaFaer commented Sep 9, 2021

@IlyaFaer IlyaFaer added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. labels Sep 9, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 9, 2021
@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/python-spanner API. label Sep 9, 2021
IlyaFaer
IlyaFaer commented Sep 9, 2021
View reviewed changes
@IlyaFaer IlyaFaer marked this pull request as ready for review September 9, 2021 15:39
@IlyaFaer IlyaFaer requested a review from a team as a code owner September 9, 2021 15:39
@IlyaFaer IlyaFaer requested a review from skuruppu September 9, 2021 15:39
@larkee larkee added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 9, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 9, 2021
@skuruppu skuruppu added the automerge Merge the pull request once unit tests and other checks pass. label Sep 9, 2021
@gcf-merge-on-green
Copy link
Contributor

gcf-merge-on-green bot commented Sep 10, 2021

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Sep 10, 2021
@IlyaFaer IlyaFaer added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 10, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 10, 2021
@larkee larkee added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 10, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 10, 2021
@IlyaFaer
Copy link
Contributor Author

IlyaFaer commented Sep 10, 2021 •
edited
Loading

A couple of sample tests failed with google.api_core.exceptions.RetryError: Deadline of 240.0s exceeded - doesn't seem to be related

@larkee larkee merged commit b5f977e into googleapis:main Sep 13, 2021
@IlyaFaer IlyaFaer deleted the user_agent branch September 13, 2021 10:44
gcf-merge-on-green bot pushed a commit that referenced this pull request Sep 21, 2021
@release-please
chore: release 3.10.0 (#567)
51fda1b 
🤖 I have created a release \*beep\* \*boop\*
---
## [3.10.0](https://www.github.com/googleapis/python-spanner/compare/v3.9.0...v3.10.0) (2021-09-17)


### Features

* set a separate user agent for the DB API ([#566](https://www.github.com/googleapis/python-spanner/issues/566)) ([b5f977e](https://www.github.com/googleapis/python-spanner/commit/b5f977ebf61527914af3c8356aeeae9418114215))


### Bug Fixes

* **db_api:** move connection validation into a separate method ([#543](https://www.github.com/googleapis/python-spanner/issues/543)) ([237ae41](https://www.github.com/googleapis/python-spanner/commit/237ae41d0c0db61f157755cf04f84ef2d146972c))
* handle google.api_core.exceptions.OutOfRange exception and throw InegrityError as expected by dbapi standards ([#571](https://www.github.com/googleapis/python-spanner/issues/571)) ([dffcf13](https://www.github.com/googleapis/python-spanner/commit/dffcf13d10a0cfb6b61231ae907367563f8eed87))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@larkee larkee larkee approved these changes

+1 more reviewer

@skuruppu skuruppu skuruppu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: spanner Issues related to the googleapis/python-spanner API. cla: yes This human has signed the Contributor License Agreement. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

feat: set user-agent string to distinguish SQLAlchemy requests

4 participants

@IlyaFaer @skuruppu @larkee @yoshi-kokoro