Skip to content

fix(deps): require google-api-core >= 1.31.5, >= 2.3.2 on v1 release #687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
busunkim96 merged 8 commits into from
Apr 6, 2022
Merged

fix(deps): require google-api-core >= 1.31.5, >= 2.3.2 on v1 release #687

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
17a1bce
chore(deps): allow google-api-core v2 on v1 release
busunkim96 Mar 11, 2022
0ac378c
chore: update google-cloud-core
busunkim96 Mar 11, 2022
5e4ae92
ci: add test dependency pytz
parthea Mar 12, 2022
6938981
chore: fix tests
parthea Mar 12, 2022
fec396e
ci: fix docfx build
parthea Mar 12, 2022
04603b4
lint
parthea Mar 12, 2022
5d53f5f
ci: add test dependency pytz
parthea Mar 13, 2022
2767644
Merge branch 'v1' into v1-api-core-pin
busunkim96 Apr 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: fix tests
  • Loading branch information
@parthea
parthea committed Mar 12, 2022
commit 69389810c3dcff20e9263db5654a7f8fd1a64fb4
6 changes: 3 additions & 3 deletions tests/unit/test_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ def _constructor_test_helper(

self.assertIs(client._credentials, expected_creds)
if expected_scopes is not None:
creds.with_scopes.assert_called_once_with(expected_scopes)
creds.with_scopes.assert_called_once_with(expected_scopes, default_scopes=None)

self.assertEqual(client.project, self.PROJECT)
self.assertIs(client._client_info, expected_client_info)
Expand Down Expand Up @@ -252,7 +252,7 @@ def test_instance_admin_api(self, mock_em):
credentials=mock.ANY, client_info=client_info, client_options=client_options
)

credentials.with_scopes.assert_called_once_with(expected_scopes)
credentials.with_scopes.assert_called_once_with(expected_scopes, default_scopes=None)

@mock.patch("google.cloud.spanner_v1.client._get_spanner_emulator_host")
def test_instance_admin_api_emulator_env(self, mock_em):
Expand Down Expand Up @@ -350,7 +350,7 @@ def test_database_admin_api(self, mock_em):
credentials=mock.ANY, client_info=client_info, client_options=client_options
)

credentials.with_scopes.assert_called_once_with(expected_scopes)
credentials.with_scopes.assert_called_once_with(expected_scopes, default_scopes=None)

@mock.patch("google.cloud.spanner_v1.client._get_spanner_emulator_host")
def test_database_admin_api_emulator_env(self, mock_em):
Expand Down