chore: restrict pubsub to < 2.0 #273
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plamut
approved these changes
Sep 16, 2020
Contributor
plamut
left a comment
There was a problem hiding this comment.
This looks good, the dependency should indeed be pinned to exclude the next major version, as major versions are generally expected to contain breaking changes.
cojenco
pushed a commit
to cojenco/python-storage
that referenced
this pull request
Oct 13, 2021
cojenco
pushed a commit
to cojenco/python-storage
that referenced
this pull request
Oct 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #272
For the passing current scenario restrict version in
nox.pyfile and for the future added in synth.py file.google-cloud-pubsub==2.0.0version has dropped the support of python2, so once storage will drop the support following changes needs to be done:replace create_topic(self.topic_path) to create_topic(name=self.topic_path)
replace get_iam_policy(self.topic_path) to get_iam_policy(request={"resource": self.topic_path})
replace set_iam_policy(self.topic_path, policy) to set_iam_policy(request={"resource": self.topic_path, "policy": policy})
replace delete_topic(self.topic_path) to delete_topic(request={"topic":self.topic_path})