fix: populate etag / generation / metageneration properties during download #488
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 6, 2021
Closed
tseaver
suggested changes
Jul 6, 2021
Contributor
tseaver
left a comment
There was a problem hiding this comment.
Thanks very much for the patch!
tseaver
approved these changes
Jul 6, 2021
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Jul 8, 2021
Support conditional requests based on ETag for read operations (`reload`, `exists`, `download_*`). My own testing seems to indicate that the JSON API does not support ETag If-Match/If-None-Match headers on modify requests (`patch`, `delete`, etc.), please correct me if I am mistaken. This part two of #451. Part one in #488. Fixes #451 🦕
cojenco
pushed a commit
to cojenco/python-storage
that referenced
this pull request
Oct 13, 2021
…wnload (googleapis#488) Populate properties during download functions via Blob._extract_headers_from_download. Additionally, update documentation for running system tests to use Python 3.8 instead of Python 3.7 to align with nox. Closes googleapis#490.
cojenco
pushed a commit
to cojenco/python-storage
that referenced
this pull request
Oct 13, 2021
Support conditional requests based on ETag for read operations (`reload`, `exists`, `download_*`). My own testing seems to indicate that the JSON API does not support ETag If-Match/If-None-Match headers on modify requests (`patch`, `delete`, etc.), please correct me if I am mistaken. This part two of googleapis#451. Part one in googleapis#488. Fixes googleapis#451 🦕
cojenco
pushed a commit
to cojenco/python-storage
that referenced
this pull request
Oct 13, 2021
…wnload (googleapis#488) Populate properties during download functions via Blob._extract_headers_from_download. Additionally, update documentation for running system tests to use Python 3.8 instead of Python 3.7 to align with nox. Closes googleapis#490.
cojenco
pushed a commit
to cojenco/python-storage
that referenced
this pull request
Oct 13, 2021
Support conditional requests based on ETag for read operations (`reload`, `exists`, `download_*`). My own testing seems to indicate that the JSON API does not support ETag If-Match/If-None-Match headers on modify requests (`patch`, `delete`, etc.), please correct me if I am mistaken. This part two of googleapis#451. Part one in googleapis#488. Fixes googleapis#451 🦕
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Populates additional properties (
etag,generation,metageneration) from the corresponding headers (ETag,x-goog-generation, andx-goog-metageneration) during download functions viaBlob._extract_headers_from_download.Additionally, update documentation for running system tests to use Python 3.8 instead of Python 3.7 to align with nox.
Closes #490.