Skip to content

Conversation

@codyoss
Copy link
Member

@codyoss codyoss commented Sep 22, 2020

  • Loosen regex on regen PR to work for all Go multi client repos
  • Only apply stricter filtering for google-cloud-go repo
  • Add test for discovery client docs

@codyoss codyoss requested a review from a team as a code owner September 22, 2020 15:38
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 22, 2020
@codecov
Copy link

codecov bot commented Sep 26, 2020

Codecov Report

Merging #554 into master will decrease coverage by 0.16%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #554      +/-   ##
==========================================
- Coverage   81.45%   81.28%   -0.17%     
==========================================
  Files          43       43              
  Lines        5086     5104      +18     
  Branches      410      373      -37     
==========================================
+ Hits         4143     4149       +6     
- Misses        942      954      +12     
  Partials        1        1              
Impacted Files Coverage Δ
src/github.ts 77.02% <100.00%> (-0.10%) ⬇️
src/releasers/go-yoshi.ts 93.68% <100.00%> (-0.51%) ⬇️
src/releasers/index.ts 85.41% <0.00%> (-2.09%) ⬇️
src/releasers/java-yoshi.ts 83.92% <0.00%> (-1.08%) ⬇️
src/releasers/simple.ts 91.75% <0.00%> (-1.04%) ⬇️
src/releasers/ruby.ts 35.34% <0.00%> (-0.87%) ⬇️
src/releasers/java-bom.ts 92.91% <0.00%> (-0.79%) ⬇️
src/release-pr.ts 90.18% <0.00%> (-0.64%) ⬇️
src/releasers/ruby-yoshi.ts 27.93% <0.00%> (-0.56%) ⬇️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5cc7583...b24b2f3. Read the comment docs.

@bcoe
Copy link

bcoe commented Oct 14, 2020

@codyoss I'll prioritize this work tomorrow 👍

@bcoe
Copy link

bcoe commented Oct 23, 2020

@codyoss I'm back on my usual schedule next week, and will help you get this over the finish line.

codyoss and others added 5 commits October 26, 2020 08:45
- Loosen regex on regen PR to work for all Go multi client repos
- Only apply stricter filtering for google-cloud-go repo
@bcoe bcoe merged commit 609164c into googleapis:master Oct 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants