Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Mihail Stoykov <[email protected]>
  • Loading branch information
olegbespalov and mstoykov authored Sep 30, 2024
1 parent 2570cd9 commit 774a421
Showing 1 changed file with 8 additions and 1 deletion.
9 changes: 8 additions & 1 deletion release notes/v0.54.0.md
Original file line number Diff line number Diff line change
Expand Up @@ -239,15 +239,22 @@ check(page, {
```

Check out [the `check` utility function's documentation](https://grafana.com/docs/k6/latest/javascript-api/jslib/utils/check/) for more information on how to use it.
### `k6/experimnetal/websockets` updates towards WebSockets API compatibility

### Support ArrayBufferViews in `send` for `k6/experimental/websockets` [#3944](https://github.com/grafana/k6/pull/3844)
#### Support ArrayBufferViews in `send` for `k6/experimental/websockets` [#3944](https://github.com/grafana/k6/pull/3844)

As part of making `k6/experimental/websockets` compliant with the [WebSocket API](https://developer.mozilla.org/en-US/docs/Web/API/WebSocket), it now supports Uint8Array and other ArrayBufferViews directly as arguments to `send`, instead of having to specifically provide their `buffer`.

This should make the module more compliant with libraries that use the WebSocket API.

Thanks to @pixeldrew for [reporting](https://github.com/grafana/xk6-websockets/issues/75) this. :bow:
#### `readyState` actually being a number [#3972](https://github.com/grafana/k6/pull/3972)

Due to goja/Sobek internal workings, `readyState` wasn't exactly a number in JavaScript code. This had some abnormal behavior, which limited interoperability with libraries.

This has been fixed, and `readyState` is a regular number from the JavaScript perspective.

Thanks to @dougw-bc for [reporting](https://github.com/grafana/xk6-websockets/issues/79) this. :bow:

### Rework of how usage is being collected internally and additional counters [`#3917`](https://github.com/grafana/k6/pull/3917) and [`#3951`](https://github.com/grafana/k6/pull/3951)

Expand Down

0 comments on commit 774a421

Please sign in to comment.