Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move cloud run and login functionalities under cloud subcommands #3813

Merged
merged 11 commits into from
Jul 24, 2024
Merged

Move cloud run and login functionalities under cloud subcommands #3813

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
3bb9797
Introduce a `k6 cloud run` command
oleiade Jun 25, 2024
c487a70
Introduce a `k6 cloud login` command
oleiade Jun 25, 2024
42f9de4
Register run and login subcommands of the cloud command
oleiade Jun 25, 2024
51427e1
Add deprecation warning to k6 login and k6 login cloud commands
oleiade Jun 25, 2024
4063228
FIXME add tests assert k6 cloud run command's arguments handling
oleiade Jun 25, 2024
231f50e
Apply Pull-Request suggestions
oleiade Jul 17, 2024
972219e
Improve cloud commands missing arguments handling
oleiade Jul 19, 2024
3965239
Apply suggestions from code review
oleiade Jul 19, 2024
2b0bc1f
Refactor cloud run command and tests to leverage existing code
oleiade Jul 23, 2024
fd6daac
Apply suggestions from code review
oleiade Jul 24, 2024
a569c16
fix lint of cmd package
oleiade Jul 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
FIXME add tests assert k6 cloud run command's arguments handling
  • Loading branch information
@oleiade
oleiade committed Jul 23, 2024
commit 40632285357adb78abdfc9d837f6e13523ceb93a
14 changes: 14 additions & 0 deletions cmd/tests/cmd_cloud_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -288,3 +288,17 @@ func TestCloudWithArchive(t *testing.T) {
assert.Contains(t, stdout, `output: https://app.k6.io/runs/123`)
assert.Contains(t, stdout, `test status: Finished`)
}

// FIXME: This test fails because our test setup leaves stdout empty
//func TestCloudArgs(t *testing.T) {
// t.Parallel()
//
// // ts := NewGlobalTestState(t)
// ts := getSimpleCloudTestState(t, nil, nil, nil, nil)
// ts.CmdArgs = []string{"k6", "cloud", "run"}
// ts.ExpectedExitCode = -1
// cmd.ExecuteWithGlobalState(ts.GlobalState)
//
// stdout := ts.Stdout.String()
// assert.Contains(t, stdout, `accepts 1 or 2 arg(s), received 0`)
//}