Fix for pricing calculation for Bundle product types when product attributes are configured#239
Merged
KrzysztofPajak merged 23 commits intograndnode:masterfrom Mar 10, 2022
Conversation
Member
|
Thanks for contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #238
Type: bugfix|
Issue
Create a product - X - with type Bundled Product.
Add the additional products - Y, Z into the bundle.
Add Product attributes at the product -X with additional price.
When the product attributes of X is changed, the price is not updated.
Solution
In the Pricing service, when the attribute values are calculated, the attribute values of the child products in the bundle are only considered.
The fix is to calculate attribute values at main product level always. And calculate the child product values only when its a bundled product.
Breaking changes
None
Testing