This repository was archived by the owner on Feb 23, 2023. It is now read-only.
json: Add fromString and try_fromString functions#217
Merged
Conversation
evaporei
commented
Oct 22, 2021
d742bd2 to
c84444d
Compare
leoyvens
suggested changes
Oct 22, 2021
common/collections.ts
Outdated
|
|
||
| let uint8Array = Uint8Array.wrap(arrayBuffer) | ||
|
|
||
| return Bytes.fromUint8Array(uint8Array) |
Collaborator
There was a problem hiding this comment.
ByteArray.fromUTF8 does the same thing, so this should probably have the same name and reuse the implementation.
Contributor
Author
There was a problem hiding this comment.
Oh shoot, great observation ❤️
Fixed!
This comment can be removed because String.UTF8.encode accepts an optional boolean argument related to the null terminator.
60907bb to
12a9e43
Compare
leoyvens
approved these changes
Oct 22, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will be helpful for NEAR subgraphs.
Related issue: https://github.com/graphprotocol/graph-ts/issues/216