pickfirst: Ensure pickfirst_test.go runs against both new and old policies #7859
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests in
pickfirst_test.go
are meant to test common behaviours of both the new and old pickfirst policies depending on which LB policy is registered under thepick_first
name. The tests were only using the old policy due to the usage of thepickfirstBuilder{}
. This change uses the balancer registry to get the builder.This change also removed the
Leaf
part in the test names, since these tests are not only for the the new pickfirst.RELEASE NOTES: N/A