Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pickfirst: Ensure pickfirst_test.go runs against both new and old policies #7859

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

arjan-bal
Copy link
Contributor

@arjan-bal arjan-bal commented Nov 20, 2024

The tests in pickfirst_test.go are meant to test common behaviours of both the new and old pickfirst policies depending on which LB policy is registered under the pick_first name. The tests were only using the old policy due to the usage of the pickfirstBuilder{}. This change uses the balancer registry to get the builder.

This change also removed the Leaf part in the test names, since these tests are not only for the the new pickfirst.

RELEASE NOTES: N/A

Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.89%. Comparing base (36d5ca0) to head (b7e0a51).
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7859      +/-   ##
==========================================
+ Coverage   81.69%   81.89%   +0.19%     
==========================================
  Files         374      375       +1     
  Lines       37978    37979       +1     
==========================================
+ Hits        31028    31104      +76     
+ Misses       5638     5577      -61     
+ Partials     1312     1298      -14     

see 25 files with indirect coverage changes

---- 🚨 Try these New Features:

@easwars easwars assigned arjan-bal and unassigned easwars Nov 20, 2024
@arjan-bal arjan-bal merged commit 7d53957 into grpc:master Nov 20, 2024
15 checks passed
@arjan-bal arjan-bal deleted the pickfirstleaf-consistent-behaviour branch November 20, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants