Skip to content

okhttp: add max connection idle at OkHttpServer and fix test#9533

Merged
YifeiZhuang merged 4 commits intogrpc:masterfrom
YifeiZhuang:okhttp-un-revert-idle-manager
Sep 9, 2022
Merged

okhttp: add max connection idle at OkHttpServer and fix test#9533
YifeiZhuang merged 4 commits intogrpc:masterfrom
YifeiZhuang:okhttp-un-revert-idle-manager

Conversation

@YifeiZhuang
Copy link
Member

@YifeiZhuang YifeiZhuang commented Sep 9, 2022

Revert "Revert "okhttp: add max connection idle at OkHttpServer (#9494)" (#9528)"
#9494

The test should wait until stream removed before idle connection manager kicks in. Use pingpong as a barrier for that.

fix #9503

@YifeiZhuang YifeiZhuang requested a review from ejona86 September 9, 2022 16:29
@YifeiZhuang YifeiZhuang merged commit eac4178 into grpc:master Sep 9, 2022
@YifeiZhuang YifeiZhuang deleted the okhttp-un-revert-idle-manager branch September 9, 2022 19:53
larry-safran pushed a commit to larry-safran/grpc-java that referenced this pull request Oct 6, 2022
* Revert "Revert "okhttp: add max connection idle at OkHttpServer (grpc#9494)" (grpc#9528)"

This reverts commit 95b9d6d and fixed flaky test.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

okhttp maxConnectionIdleTimer_respondWithError is flaky

2 participants