Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

everything works as expected now. #3

Merged
merged 16 commits into from
Jan 11, 2012
Merged

everything works as expected now. #3

merged 16 commits into from
Jan 11, 2012

Conversation

rofl0r
Copy link
Contributor

@rofl0r rofl0r commented Sep 10, 2011

No description provided.

@rofl0r
Copy link
Contributor Author

rofl0r commented Sep 11, 2011

summary of the changes

  • removes the outdated gnu automake/autoconf stuff, replaces it with a single, simple makefile
  • fixed getnameinfo, which was using a wrong prototype (it used the bugged prototype from glibc < 2.14)
  • compiles with musl libc as well as glibc now. possibly it now works even on mac
  • make main.c work, because the proxychains bash script cannot be used with gdb
  • fix all occurences of int where either socklen_t is expected or an unsigned int, because the number cant be negative
  • added gethostbyaddr hook code
  • fixed a nasty bug detected by gcc's -Wall -Wextra switches (assignment in while condition without surrounding braces)

@rofl0r
Copy link
Contributor Author

rofl0r commented Nov 6, 2011

you may also want to take a look at https://github.com/rofl0r/proxychains/commits/remote-dns

in this branch, i have entirely eliminated the need for the crappy dnsresolver script.

the dns resolving is done on the server side, using socksv4a and socksv5 dns methods, and http should support it as well.

the big advantages are:

  • the identity cannot be leaked anymore through a wrongly set up dig command (i.e. statically linked).
  • it's much faster because the startup of an external script and dns resolving via TCP is quite slow.
  • no external dependencies.
  • it now even works with .onion domains

plain SOCKS4 won't work anymore with DNS resolution (only with numeric ips passed to the program), but i'm not aware of any socksv4 only socksserver in common use. and if there are some, it's about time to get them fixed to support the simple v4a extension.

@jianingy
Copy link
Contributor

jianingy commented Nov 7, 2011

Wow, the remote-dns is really a great work. I was think about it, but had no idea how to implement. Thanks for it, rofl0r.

haad added a commit that referenced this pull request Jan 11, 2012
everything works as expected now.
@haad haad merged commit 9a29a4c into haad:master Jan 11, 2012
@haad
Copy link
Owner

haad commented Jan 11, 2012

I have merged your changes to proxychains repository thanks for your work & help !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants