Skip to content

Fix missing renderer and editor prop in react wrapper #10768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
adrianspdev merged 8 commits into from
Feb 19, 2024
Merged

Fix missing renderer and editor prop in react wrapper #10768

adrianspdev merged 8 commits into from
Feb 19, 2024

Conversation

@adrianspdev
Copy link
Contributor

@adrianspdev adrianspdev commented Feb 7, 2024 •
edited
Loading

Context

This PR contains fix for cell renderer and editor prop in react wrapper

How has this been tested?

manual tests
automated tests

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature or improvement (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Additional language file or change to the existing one (translations)

Related issue(s):

  1. https://github.com/handsontable/dev-handsontable/issues/1736

Affected project(s):

  • handsontable
  • @handsontable/angular
  • @handsontable/react
  • @handsontable/vue
  • @handsontable/vue3

Checklist:

  • The renderer prop is present on cell meta.
  • The editor prop is present on cell meta.

@adrianspdev adrianspdev requested review from budnix and evanSe February 7, 2024 07:31
@adrianspdev adrianspdev self-assigned this Feb 7, 2024
budnix
budnix requested changes Feb 7, 2024
View reviewed changes
budnix
budnix previously approved these changes Feb 7, 2024
View reviewed changes
Copy link
Member

@budnix budnix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@evanSe evanSe mentioned this pull request Feb 8, 2024
Merged
11 tasks
@github-actions
Copy link

github-actions bot commented Feb 19, 2024 •
edited
Loading

Launch the local version of documentation by running:

npm run docs:review c12c0647e54d2a373247a57e015405ecff635bf9

@adrianspdev adrianspdev merged commit cf403dc into develop Feb 19, 2024
@adrianspdev adrianspdev deleted the feature/dev-issue-1736 branch February 19, 2024 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@budnix budnix budnix approved these changes

@evanSe evanSe Awaiting requested review from evanSe

Assignees

@adrianspdev adrianspdev

Labels

Status: Released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@adrianspdev @budnix @AMBudnik @evanSe