Skip to content

Conversation

@jansiegel
Copy link
Member

Context

The problem described in handsontable/dev-handsontable#1610 was caused by logic that made all the rows re-render when trying to render the table if it was placed in a hidden (display: none) container.

Initially, I wanted to tackle just this issue, but ended up disabling the ability to render the table when it's hidden.
Personally, I can't think of a scenario where this would be needed, but if I'm missing something, just let me know.

How has this been tested?

  • Added a test case for disabling the rendering for the hidden instances
  • Added a test case specifically for handsontable/dev-handsontable#1610

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature or improvement (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Additional language file or change to the existing one (translations)

Related issue(s):

  1. handsontable/dev-handsontable#1610

Affected project(s):

  • handsontable
  • @handsontable/angular
  • @handsontable/react
  • @handsontable/vue
  • @handsontable/vue3

Checklist:

@jansiegel jansiegel self-assigned this May 21, 2024
@jansiegel jansiegel marked this pull request as ready for review May 21, 2024 07:06
@jansiegel jansiegel requested a review from budnix May 21, 2024 07:06
@jansiegel jansiegel merged commit 141c119 into develop May 21, 2024
@jansiegel jansiegel deleted the feature/dev-issue-1610 branch May 21, 2024 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants