Skip to content

Reset the internal offset values after disabling navigableHeaders #11043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jansiegel merged 2 commits into from
Jun 20, 2024
Merged

Reset the internal offset values after disabling navigableHeaders #11043

jansiegel merged 2 commits into from
Jun 20, 2024

Conversation

@jansiegel
Copy link
Member

@jansiegel jansiegel commented Jun 20, 2024

Context

This PR:

  • Resets the internal offset values of the Transformation class to 0 if navigableHeaders was disabled
  • Adds test cases to cover the problem from handsontable/dev-handsontable#1942

How has this been tested?

  • Added test cases to cover the problem from handsontable/dev-handsontable#1942

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature or improvement (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Additional language file or change to the existing one (translations)

Related issue(s):

  1. handsontable/dev-handsontable#1942

Affected project(s):

  • handsontable
  • @handsontable/angular
  • @handsontable/react
  • @handsontable/vue
  • @handsontable/vue3

Checklist:

@jansiegel jansiegel self-assigned this Jun 20, 2024
@jansiegel jansiegel marked this pull request as ready for review June 20, 2024 13:24
@jansiegel jansiegel requested a review from budnix June 20, 2024 13:24
@jansiegel jansiegel merged commit 0879a9d into develop Jun 20, 2024
@jansiegel jansiegel deleted the feature/dev-issue-1942 branch June 20, 2024 13:29
evanSe pushed a commit that referenced this pull request Jul 16, 2024
@jansiegel @evanSe
Reset the internal offset values after disabling navigableHeaders (#…
13b9ff9 
…11043)

* - Reset the offset values after disabling 'navigableHeaders'
- Add test cases

* Add the changelog entry
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@budnix budnix budnix approved these changes

Assignees

@jansiegel jansiegel

Labels

Status: Released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jansiegel @budnix @adrianszymanski89