Skip to content

Conversation

@budnix
Copy link
Member

@budnix budnix commented Nov 26, 2024

Context

The PR fixes an error that could happen when the keyboard event was triggered with a key property as undefined. That could happen when the event was emulated by the 3rd party developer's app or IME.

How has this been tested?

I tested the changes locally and I covered the fix with a new test.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Related issue(s):

  1. fixes https://github.com/handsontable/dev-handsontable/issues/2096

Affected project(s):

  • handsontable

Checklist:

@budnix budnix self-assigned this Nov 26, 2024
@budnix budnix marked this pull request as ready for review November 26, 2024 11:45
@budnix budnix requested a review from jansiegel November 26, 2024 11:45
@codesandbox-ci
Copy link

codesandbox-ci bot commented Nov 26, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit ec5ae27:

Sandbox Source
handsontable-pr-javascript-demo Configuration
handsontable-ts-demo Configuration
handsontable-pr-react-demo Configuration

@github-actions
Copy link

Launch the local version of documentation by running:

npm run docs:review ec5ae27a238299b4baad45d1134d69a1b33ebf77

@budnix budnix merged commit 9f74e1b into develop Nov 28, 2024
26 checks passed
@budnix budnix deleted the feature/dev-issue-2096 branch November 28, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants