Skip to content

Conversation

@budnix
Copy link
Member

@budnix budnix commented Dec 12, 2024

Context

The PR fixes the bug where the viewport was incorrectly scrolled after the row moved. The bug only occurred when the NestedRows plugin was enabled. The fix changes the API for selection that allows disabling scrolling.

How has this been tested?

I tested the changes locally and I covered the fix with a new test.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Related issue(s):

  1. fixes https://github.com/handsontable/dev-handsontable/issues/2103

Affected project(s):

  • handsontable

Checklist:

@budnix budnix self-assigned this Dec 12, 2024
@budnix budnix marked this pull request as ready for review December 12, 2024 13:28
@budnix budnix requested a review from jansiegel December 12, 2024 13:28
@codesandbox-ci
Copy link

codesandbox-ci bot commented Dec 12, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 7a4c1e9:

Sandbox Source
handsontable-pr-javascript-demo Configuration
handsontable-ts-demo Configuration
handsontable-pr-react-demo Configuration

@github-actions
Copy link

Launch the local version of documentation by running:

npm run docs:review 7a4c1e9855d52ab57ed46e8cdcab3c256309ed27

@budnix budnix merged commit 0464ff4 into develop Dec 17, 2024
30 checks passed
@budnix budnix deleted the feature/dev-issue-2103 branch December 17, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants