Skip to content

Conversation

@budnix
Copy link
Member

@budnix budnix commented Feb 14, 2025

Context

The PR includes fixes:

  • Optimize the table selectors responsible for border-radius (thanks, @adrianspdev, for help);
  • Fix missing htColumnHeaders class for nested headers;
  • Optimize the selectors responsible for selection header borders (thanks, @adrianspdev, for help);

All those optimizations result in rendering the table almost twice as fast.

Navigation by arrow down from the topmost viewport:

image

Faster ~90% in fast render and 100% in slow render phase.

Navigation by arrow right from the middle of the viewport:

image

Faster ~70% in fast render and 40% in slow render phase.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Related issue(s):

  1. https://github.com/handsontable/dev-handsontable/issues/2234

Affected project(s):

  • handsontable

Checklist:

@budnix budnix self-assigned this Feb 14, 2025
@budnix budnix marked this pull request as ready for review February 14, 2025 13:11
@codesandbox-ci
Copy link

codesandbox-ci bot commented Feb 14, 2025

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit f655319:

Sandbox Source
handsontable-pr-javascript-demo Configuration
handsontable-ts-demo Configuration
handsontable-pr-react-demo Configuration

@budnix budnix requested a review from adrianspdev February 19, 2025 08:27
@github-actions
Copy link

Launch the local version of documentation by running:

npm run docs:review f655319fd16f670e546a4176c71765c3292a1003

@budnix budnix requested a review from jansiegel February 19, 2025 08:56
@budnix budnix merged commit b880b30 into develop Feb 19, 2025
31 checks passed
@budnix budnix deleted the feature/dev-issue-2234-fix branch February 19, 2025 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants