Skip to content

Conversation

@budnix
Copy link
Member

@budnix budnix commented Feb 20, 2025

Context

The PR fixes the hasVerticalScroll and hasHorizontalScroll methods, affecting the overlays to have a wrong size. From now on, the updated logic supports both renderings. In the window (window as a scrollable element) and the element (table with a defined size).

How has this been tested?

I tested the changes locally, and I covered the fix with new tests.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Related issue(s):

  1. fixes https://github.com/handsontable/dev-handsontable/issues/2248

Affected project(s):

  • handsontable

Checklist:

@budnix budnix self-assigned this Feb 20, 2025
@budnix budnix marked this pull request as ready for review February 20, 2025 12:52
@budnix budnix requested a review from jansiegel February 20, 2025 12:53
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 6b3ded5:

Sandbox Source
handsontable-pr-javascript-demo Configuration
handsontable-ts-demo Configuration
handsontable-pr-react-demo Configuration

@github-actions
Copy link

Launch the local version of documentation by running:

npm run docs:review 6b3ded539966231e92fa279ccd6478aba4625198

@budnix budnix merged commit e2a5d5f into develop Feb 21, 2025
31 checks passed
@budnix budnix deleted the feature/dev-issue-2248 branch February 21, 2025 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants