Skip to content

Conversation

@budnix
Copy link
Member

@budnix budnix commented Feb 21, 2025

Context

The PR fixes the overlay's misalignment for overlays that contain merge cells. The reason for the misalignment was the incorrect height of the first row, which is the only one that receives the border-width attribute of 1px for the top, which causes the content in the cells to be pushed by 1px (as the box-sizing is set as border-box). The fix compensates for that 1px in CSS.

How has this been tested?

I tested the changes locally, and I updated the tests according to the changes.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Related issue(s):

  1. fixes https://github.com/handsontable/dev-handsontable/issues/2252

Affected project(s):

  • handsontable

Checklist:

@budnix budnix self-assigned this Feb 21, 2025
@codesandbox-ci
Copy link

codesandbox-ci bot commented Feb 21, 2025

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit fb88316:

Sandbox Source
handsontable-pr-javascript-demo Configuration
handsontable-ts-demo Configuration
handsontable-pr-react-demo Configuration

@budnix budnix marked this pull request as ready for review February 24, 2025 11:02
@budnix budnix requested a review from adrianspdev February 24, 2025 11:03
@budnix budnix merged commit 326182b into develop Feb 25, 2025
29 of 30 checks passed
@budnix budnix deleted the feature/dev-issue-2252 branch February 25, 2025 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants