Skip to content

Conversation

@budnix
Copy link
Member

@budnix budnix commented Mar 19, 2025

Context

The PR fixes the comments functionality, which does not work correctly when the typed values come from the IME. A new hook (beforeCompositionStart) had to be introduced to fix the issue. The hook allows implementing custom handling or blocking of core logic when the IME is used.

How has this been tested?

I tested the changes locally, and I covered the fix and a new hook with tests.

Types of changes

  • New feature or improvement (non-breaking change which adds functionality)

Related issue(s):

  1. fixes https://github.com/handsontable/dev-handsontable/issues/2281

Affected project(s):

  • handsontable
  • @handsontable/angular

Checklist:

@budnix budnix self-assigned this Mar 19, 2025
@budnix budnix marked this pull request as ready for review March 19, 2025 10:27
@budnix budnix requested review from jansiegel and qunabu March 19, 2025 10:28
@codesandbox-ci
Copy link

codesandbox-ci bot commented Mar 19, 2025

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit e0ddfe8:

Sandbox Source
handsontable-pr-javascript-demo Configuration
handsontable-ts-demo Configuration
handsontable-pr-react-demo Configuration

qunabu
qunabu previously approved these changes Mar 19, 2025
@github-actions
Copy link

Launch the local version of documentation by running:

npm run docs:review 0f433845196e1dc01e6f314dd42e15d5aa5f5277

@budnix budnix merged commit 099f053 into develop Mar 20, 2025
32 checks passed
@budnix budnix deleted the feature/dev-issue-2281 branch March 20, 2025 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants