Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
The PR fixes the comments functionality, which does not work correctly when the typed values come from the IME. A new hook (
beforeCompositionStart) had to be introduced to fix the issue. The hook allows implementing custom handling or blocking of core logic when the IME is used.How has this been tested?
I tested the changes locally, and I covered the fix and a new hook with tests.
Types of changes
Related issue(s):
Affected project(s):
handsontable@handsontable/angularChecklist: