Skip to content

Conversation

@budnix
Copy link
Member

@budnix budnix commented Apr 1, 2025

Context

The PR improves the Filter's "by value" component by adding a horizontal scroll when the width of the values is wider than the component viewport size.

Before

Kapture 2025-04-01 at 09 41 25

After

Kapture 2025-04-01 at 09 42 17

How has this been tested?

I tested the changes locally, and I covered the fix with updated tests.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Related issue(s):

  1. fixes https://github.com/handsontable/dev-handsontable/issues/1863

Affected project(s):

  • handsontable

Checklist:

@budnix budnix self-assigned this Apr 1, 2025
@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 1, 2025

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 2acb168:

Sandbox Source
handsontable-pr-javascript-demo Configuration
handsontable-ts-demo Configuration
handsontable-pr-react-demo Configuration

@budnix budnix marked this pull request as ready for review April 1, 2025 10:17
@budnix budnix requested review from adrianspdev and qunabu April 1, 2025 10:18
adrianspdev
adrianspdev previously approved these changes Apr 1, 2025
adrianspdev
adrianspdev previously approved these changes Apr 1, 2025
@budnix budnix merged commit 1f4aee2 into develop Apr 1, 2025
31 checks passed
@budnix budnix deleted the feature/dev-issue-1863-v2 branch April 1, 2025 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants