-
Notifications
You must be signed in to change notification settings - Fork 146
Refactor DependencyGraph to enable loading big spreadsheets #1604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sequba
wants to merge
8
commits into
develop
Choose a base branch
from
feature/issue-1602
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* remove nodeids map and store node id directly * add _graphId property --------- Co-authored-by: Kuba Sekowski <[email protected]>
Performance comparison of head (5cdf351) vs base (f706d17) |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1604 +/- ##
========================================
Coverage 97.17% 97.18%
========================================
Files 170 172 +2
Lines 14785 14800 +15
Branches 3245 3246 +1
========================================
+ Hits 14368 14383 +15
Misses 409 409
Partials 8 8
🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Replaced the internal
nodesIds: Map<Node, NodeId>in theGraphclass with a directidInGraphproperty stored on each node. This eliminates the Map that could exceed maximum size limits when loading large spreadsheets with many cells.Co-authored by @Krizz (#1597)
Changes:
GraphNodeinterface withidInGraphpropertyVertexabstract base class implementingGraphNodeCellVertexabstract class extendingVertexfor cell-type verticesnodesIdsMap fromGraphclassgetNodeId()public method (now accessnode.idInGraphdirectly)getInfiniteRanges()return type fromNodeAndId<Node>[]toNode[]How did you test your changes?
Map maximum size exceededwhen loading a 30-milion-cell worksheet #1602 worksTypes of changes
Related issues:
Map maximum size exceededwhen loading a 30-milion-cell worksheet #1602Checklist: