Skip to content

Function FORMULATEXT #422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
voodoo11 merged 8 commits into from
Jul 24, 2020
Merged

Function FORMULATEXT #422

voodoo11 merged 8 commits into from
Jul 24, 2020

Conversation

@voodoo11
Copy link
Collaborator

@voodoo11 voodoo11 commented Jun 26, 2020

Context

Introduces FORMULATEXT function

How has this been tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature or improvement (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Additional language file or change to the existing one (translations)

Related issue(s):

  1. Functions to be added after the initial release #221

Checklist:

  • My code follows the code style of this project,
  • My change requires a change to the documentation,
  • I described the modification in the CHANGELOG.md file.

@voodoo11 voodoo11 changed the title Jk/function formulatext function FORMULATEXT Jun 26, 2020
@voodoo11 voodoo11 mentioned this pull request Jun 26, 2020
Closed
46 tasks
@voodoo11 voodoo11 changed the title function FORMULATEXT Function FORMULATEXT Jun 26, 2020
wojciechczerniak
wojciechczerniak suggested changes Jun 26, 2020
View reviewed changes
Copy link
Contributor

@wojciechczerniak wojciechczerniak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the destination branch to develop

@wojciechczerniak wojciechczerniak self-assigned this Jun 26, 2020
@voodoo11 voodoo11 changed the base branch from master to develop June 26, 2020 12:07
@wojciechczerniak wojciechczerniak self-requested a review June 26, 2020 12:09
wojciechczerniak
wojciechczerniak suggested changes Jul 20, 2020
View reviewed changes
Copy link
Contributor

@wojciechczerniak wojciechczerniak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add the new function to the changelog.md?

@wojciechczerniak
Copy link
Contributor

wojciechczerniak commented Jul 20, 2020

Functions should also be added to the documentation:

https://github.com/handsontable/hyperformula/blob/develop/docs/guide/built-in-functions.md

wojciechczerniak
wojciechczerniak approved these changes Jul 24, 2020
View reviewed changes
Copy link
Contributor

@wojciechczerniak wojciechczerniak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx! 🥇

@voodoo11 voodoo11 merged commit 3957b40 into develop Jul 24, 2020
@scarletfog scarletfog mentioned this pull request Sep 18, 2020
Closed
6 tasks
@wojciechczerniak wojciechczerniak deleted the jk/function-formulatext branch September 15, 2021 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@wojciechczerniak wojciechczerniak wojciechczerniak approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@voodoo11 voodoo11

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@voodoo11 @wojciechczerniak