Skip to content

Conversation

@izulin
Copy link
Collaborator

@izulin izulin commented Nov 4, 2020

Context

SCC code was not handling some of the logic correctly. The code is now simpler and correcter.

How has this been tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature or improvement (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Additional language file or change to the existing one (translations)

Related issue(s):

  1. setSheetContent internal error #561

Checklist:

  • My code follows the code style of this project,
  • My change requires a change to the documentation,
  • I described the modification in the CHANGELOG.md file.

@codecov
Copy link

codecov bot commented Nov 4, 2020

Codecov Report

Merging #563 into develop will decrease coverage by 0.00%.
The diff coverage is 88.23%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #563      +/-   ##
===========================================
- Coverage    91.90%   91.90%   -0.01%     
===========================================
  Files          161      161              
  Lines        33495    33487       -8     
  Branches      3132     3130       -2     
===========================================
- Hits         30785    30777       -8     
  Misses        2704     2704              
  Partials         6        6              
Impacted Files Coverage Δ
src/DependencyGraph/Graph.ts 93.00% <88.23%> (-0.17%) ⬇️

Copy link
Collaborator

@bardek8 bardek8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I added only some small comments to rename variables, to make it easier to read in the future.

I would also add a comment at the top of this function that it's an iterative implementation of Tarjan's algorithm for finding strongly connected compontents.

@izulin izulin merged commit c509381 into develop Nov 4, 2020
@izulin izulin deleted the pu/internalerror branch November 4, 2020 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants