fix TypeError if path /constructor/foo is accessed #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Haha, interesting! Looks good to me. |
If there are any literals available in the router, then any access to a path with
multiple segments and its first segment an object prototype property lead to a
TypeError.
This fixes these TypeErrors by checking whether the property is the literal list's own.
There is a similar code path for the `this._fulls` but the path always contains a leading slash,
thus is not vulnerable to such error.
```
Debug: internal, implementation, error
TypeError: match.lookup is not a function
at Object.internals.deeper (/some-project/node_modules/hapi/node_modules/call/lib/segment.js:240:28)
at internals.Segment.lookup (/some-project/node_modules/hapi/node_modules/call/lib/segment.js:177:36)
at internals.Router._lookup (/some-project/node_modules/hapi/node_modules/call/lib/index.js:113:28)
at internals.Router.route (/some-project/node_modules/hapi/node_modules/call/lib/index.js:94:22)
at internals.Request._lifecycle (/some-project/node_modules/hapi/lib/request.js:343:41)
at internals.Request._execute (/some-project/node_modules/hapi/lib/request.js:312:21)
at Domain.<anonymous> (/some-project/node_modules/hapi/lib/connection.js:253:25)
at Domain.run (domain.js:191:14)
at internals.Protect.enter (/some-project/node_modules/hapi/lib/protect.js:84:17)
at Server.internals.Connection._dispatch (/some-project/node_modules/hapi/lib/connection.js:251:30)
```
Contributor
Author
|
I rebased and updated changes to es6 |
Contributor
|
Need to fix the linting issues. I might implement this differently but worth getting this PR finished. |
Contributor
Author
|
@hueniverse fixed. Feel free to adjust as you wish |
|
This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there are any literals available in the router, then any access to a path with
multiple segments and its first segment an object prototype property, lead to a
TypeError.
This fixes these TypeErrors by checking whether the property is the literal list's own.
There is a similar code path for the
this._fullsbut the path always contains a leading slash,thus is not vulnerable to such error.