print expected value on equals assertion #101
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjihrig
requested changes
Jun 1, 2017
lib/index.js
Outdated
| : (a, b) => Hoek.deepEqual(a, b, settings); | ||
|
|
||
| return this.assert(compare(this._ref, value), 'equal specified value', this._ref, value); | ||
| return this.assert(compare(this._ref, value), `equal specified value: ${JSON.stringify(value)}`, this._ref, value); |
Contributor
There was a problem hiding this comment.
I think this should use util.inspect() instead of JSON.stringify().
Contributor
|
I just updated |
Contributor
|
Landed in 38df73b. Thanks! |
|
This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
open to suggestions on other ways of printing both the actual and expected value on a failed equals assertion, this is a shot in the dark