Skip to content

Conversation

@manonthemat
Copy link
Contributor

No description provided.

.gitignore Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove this please.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you don't like vim (users)? 😕

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't use it personally, but I checked a couple other .gitignore files in hapi repos and didn't see it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's fine with me, just makes it easier for people using vim not to include (swap) files that they are working on accidentally. I've seen other editor files in the .gitignore, so I felt it would help. But if it's the standard in the hapijs repositories not to include it, then that's absolutely fine with me. But that may mean that you guys need (more) vim users. ;)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't had a .swp file in ages for my vim setup. Most likely because I have this option set set noswapfile

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the tip 👍

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@manonthemat the default file for the global ignore file is actually $HOME/.config/git/ignore. There's no need to set it to something else as in the link by @gergoerdosi

@cjihrig
Copy link
Contributor

cjihrig commented Aug 28, 2015

Thanks!

cjihrig added a commit that referenced this pull request Aug 28, 2015
@cjihrig cjihrig merged commit 40de6a2 into hapijs:master Aug 28, 2015
@cjihrig cjihrig added the documentation Non-code related changes label Aug 28, 2015
@cjihrig cjihrig added this to the 1.5.1 milestone Aug 28, 2015
@cjihrig cjihrig self-assigned this Aug 28, 2015
@lock
Copy link

lock bot commented Jan 9, 2020

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

documentation Non-code related changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants