Add error type (fixes #61) #62
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| internals.addMethod(word, method); | ||
| }); | ||
|
|
||
| internals.addMethod('error', function (/*type, message*/) { |
Contributor
There was a problem hiding this comment.
I feel like there is some DRY that could be applied here.
Contributor
Author
There was a problem hiding this comment.
Considering the logic and the error strings are slightly different, I can't see any re-use.
Contributor
|
Can you add a test showing |
Contributor
Author
|
It should be OK now, the logic on the not was wrong, so good gatekeeping here ;) |
Contributor
|
no api docs update 😢 |
Contributor
Contributor
Author
|
Dammit ! I always forget that ! Sorry. |
Contributor
Author
|
Done as #64. |
Contributor
|
@Marsup just published [email protected] |
|
This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly ripoff of the throw code with small adjustments in the tests because I considered not passing a type should still check whether that's an error type or not, I'd argue the throw logic is wrong on this side.