Reference value NaN assertion. #94
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjihrig
requested changes
Nov 18, 2016
Contributor
cjihrig
left a comment
There was a problem hiding this comment.
There is a difference between the behavior of isNaN() and Number.isNaN(). Since this is only targeting the NaN value, this should use Number.isNaN(). Please add a test that asserts a string to see the difference.
API.md
Outdated
|
|
||
| ##### `NaN()` | ||
|
|
||
| Asserts that the reference value is NaN. |
Contributor
There was a problem hiding this comment.
NaN should be in backticks.
lib/index.js
Outdated
|
|
||
| internals.addMethod('NaN', function () { | ||
|
|
||
| return this.assert(isNaN(this._ref), 'be NaN'); |
8216913 to
cca691f
Compare
Contributor
|
This still needs a test for a string. |
cca691f to
1de2fa0
Compare
Contributor
|
Landed with some edits in 3d9dfc3. |
|
This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To check whether the reference value is NaN or not.
For Example: