fix: never instrument eslint configs for coverage #1016
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is an alternative fix to the issue we saw where we'd blow up the call stack when the test runner tried to instrument the eslint config. adding our own internal eslint config to the coverage exclusions did so in too specific of a way, so instead i tweaked the require extension such that it will never instrument an eslint config of any type.
this is necessary to make it so users don't have to explicitly ignore their own
.eslintrc.jsif they have one