Skip to content

Conversation

@nlf
Copy link
Member

@nlf nlf commented Jul 12, 2021

this is an alternative fix to the issue we saw where we'd blow up the call stack when the test runner tried to instrument the eslint config. adding our own internal eslint config to the coverage exclusions did so in too specific of a way, so instead i tweaked the require extension such that it will never instrument an eslint config of any type.

this is necessary to make it so users don't have to explicitly ignore their own .eslintrc.js if they have one

@Nargonath Nargonath added the bug Bug or defect label Jul 13, 2021
@Nargonath Nargonath added this to the v24.3.1 milestone Jul 13, 2021
@nlf nlf merged commit c0bd048 into master Jul 13, 2021
@Nargonath Nargonath deleted the nlf/fix-eslint-config-recursion branch July 13, 2021 14:08
@Nargonath Nargonath modified the milestones: v24.3.1, v24.3.2 Jul 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Bug or defect

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants