Feature - Prevent clobbered timer globals from interfering with runner #164
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…subsequent global clobbering
Member
There was a problem hiding this comment.
Please add a newline after each function declaration: https://github.com/hapijs/hapi/blob/master/docs/Style.md
geek
added a commit
that referenced
this pull request
Aug 19, 2014
Feature - Prevent clobbered timer globals from interfering with runner
Closed
|
This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sinon.jsexposes a functionality that mocks global timing functions. This change will save a reference to the global timing functions to prevent subsequent clobbering from affectingrunner.jsSee also: https://github.com/visionmedia/mocha/blob/master/lib/runnable.js#L10-L18
@chapel