-
Notifications
You must be signed in to change notification settings - Fork 176
WIP - Add linting support #213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
bin/_lab
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
else on newline
|
I like this approach, be sure to add more tests and document the option in the readme. |
|
Updated the PR with these suggestions. I've actually spent a lot of time trying to find the correct settings to validate lab itself. If you have better rules before starting writing our own, I'll take em :) |
|
@Marsup thanks, I'll merge this after 4.5.2. Maybe we should start with only a few rules? |
|
@Marsup any chance that you can add some tests for the new option? |
|
Sure, I'll hopefully complete coverage in a few days, just a bit busy currently. |
|
@geek Coverage is good now, linting doesn't make a test run fail though, but at least it's usable until we manage to find rules that fit the projects. Travis's output is weird, a red cross but no error, I don't get it. |
|
Thanks for this, it will be a huge help |
* based on last activity on Lab (hapijs/lab#213) * make all rules that are best practices, but not in styleguide as warnings
|
This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions. |
Hello,
As discussed in outmoded/discuss#22, I'm trying to implement linting in lab.
This is a WIP and shouldn't be merged right now as tests are not even done.
So far I only have support for eslint, I included @geek's rules but lab itself is full of errors so it'll need tweaking.
It will automatically detect eslint settings at the root of the project and if none use what should be our default rules.
The possibility to have multiple linters is deliberate and probably wanted.
Console output was faster to implement but others will follow.
I'd like feedback about my approach.
Thanks.