make linter pluggable #290
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
initial work: jslint runs but writes to stdout instead of returning data update tests to use -L, -n to specify linter style: remove dangling comma spacing and intentation rename linter output to "lint" from "eslint" implement runner; add tests, fixtures for jslint restore newlines hoist helper functions add jslint (w/version) as optional dependency
Contributor
|
Isn't this a 5.2.0? |
Member
|
@hueniverse yes, hadn't got to reviewing fully to make that switch. Thanks. |
Contributor
|
For what it's worth, I still believe a single switch is achievable :p |
Contributor
Author
lib/linters/jslint/index.js
Outdated
Member
There was a problem hiding this comment.
Our styles a little different, 4 spaces and a newline after each function declaration.
Contributor
Author
|
More like that? |
Member
|
@smikes perfect, thanks I'll publish this later tonight. Want to run through it all |
Closed
|
This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
initial work: jslint runs but writes to stdout instead of returning data
update tests to use -L, -n to specify linter
style: remove dangling comma
spacing and intentation
rename linter output to "lint" from "eslint"
implement runner; add tests, fixtures for jslint
restore newlines
hoist helper functions
add jslint (w/version) as optional dependency