Skip to content

Support custom reporters - closes #216 & closes #309 #317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
geek merged 1 commit into from
Mar 4, 2015
Merged

Support custom reporters - closes #216 & closes #309 #317

geek merged 1 commit into from
Mar 4, 2015

Conversation

@phated
Copy link
Contributor

@phated phated commented Mar 3, 2015

The implementation I went with is: if a string passed to the reporter option doesn't exist in the internals.proto map, just attempt to require it. I also added simple logic for relative vs npm-installed reporters.

geek
geek reviewed Mar 4, 2015
View reviewed changes
lib/reporters/index.js Outdated
Copy link
Member

@geek geek Mar 4, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

our style is to add a newline when we create new scopes: http://hapijs.com/styleguide

Copy link
Contributor

@Marsup Marsup Mar 4, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also reporter[0] === '.' ?

@geek
Copy link
Member

geek commented Mar 4, 2015

Please add documentation to the readme about this enhancement, and how the require works.

@geek geek added the feature New functionality or improvement label Mar 4, 2015
@geek geek self-assigned this Mar 4, 2015
@phated phated force-pushed the custom-reporters branch 2 times, most recently from e9693b8 to 6cc9957 Compare March 4, 2015 18:25
@phated phated force-pushed the custom-reporters branch from 964b8ce to dc8cdd6 Compare March 4, 2015 18:36
@phated
Copy link
Contributor Author

phated commented Mar 4, 2015

Updated, rebased and added documentation.

@geek geek added this to the 5.4.1 milestone Mar 4, 2015
@geek geek changed the title add support for custom reporters - closes #216 & closes #309 Support custom reporters - closes #216 & closes #309 Mar 4, 2015
geek added a commit that referenced this pull request Mar 4, 2015
@geek
Merge pull request #317 from iceddev/custom-reporters
72d3a70 
Support custom reporters - closes #216 & closes #309
@geek geek merged commit 72d3a70 into hapijs:master Mar 4, 2015
@geek
Copy link
Member

geek commented Mar 4, 2015

@phated nice work!

@lock
Copy link

lock bot commented Jan 9, 2020

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@geek geek

Labels

feature New functionality or improvement

Projects

None yet

Milestone

5.5.0

Development

Successfully merging this pull request may close these issues.

3 participants

@phated @geek @Marsup